Conversation
Signed-off-by: tison <wander4096@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s development dependency lockfile and refactors the helper script used to download/extract serialization snapshot test data into the datasketches/tests/serialization_test_data directories.
Changes:
- Refactor
tools/download_serialization_test_data.pyto pass explicit destination paths and inline the archive URL/config mapping. - Update
Cargo.lockto reflect upgraded (dev) dependency versions and the resulting resolved dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/download_serialization_test_data.py | Refactors snapshot download/extraction flow and target path handling. |
| Cargo.lock | Regenerated lockfile capturing upgraded dependency versions/resolution changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tisonkun
enabled auto-merge (squash)
July 25, 2026 00:07
PsiACE
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.