Skip to content

feat: AoS tuple sketch#476

Open
proost wants to merge 16 commits intoapache:masterfrom
proost:feat-aos-tuple-sketch
Open

feat: AoS tuple sketch#476
proost wants to merge 16 commits intoapache:masterfrom
proost:feat-aos-tuple-sketch

Conversation

@proost
Copy link
Member

@proost proost commented Jan 27, 2026

issue: #475

I change original design. I will follow same design with array of doubles sketch, that allow allocator for container not the element of container. I think using standard allocator for string is fine, for consistency of code following same design is good And even if we use custom allocator, we can't use completely for string allocation because of serialization and deserialization.

even though above reasons, if want to change to orignal design, it is acceptable.

@proost proost self-assigned this Jan 27, 2026
@coveralls
Copy link

coveralls commented Jan 27, 2026

Pull Request Test Coverage Report for Build 21757025873

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 215 of 264 (81.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/include/third_party/utf8cpp/utf8/core.h 62 111 55.86%
Totals Coverage Status
Change from base Build 20975908107: -0.3%
Covered Lines: 17263
Relevant Lines: 17520

💛 - Coveralls

@proost proost requested a review from jmalkin February 7, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants