Minor: move AnalysisContext out of physical_expr and into its own module#7127
Merged
alamb merged 1 commit intoapache:mainfrom Jul 30, 2023
Merged
Minor: move AnalysisContext out of physical_expr and into its own module#7127alamb merged 1 commit intoapache:mainfrom
AnalysisContext out of physical_expr and into its own module#7127alamb merged 1 commit intoapache:mainfrom
Conversation
alamb
commented
Jul 28, 2023
| /// The shared context used during the analysis of an expression. Includes | ||
| /// the boundaries for all known columns. | ||
| #[derive(Clone, Debug, PartialEq)] | ||
| pub struct AnalysisContext { |
Contributor
Author
There was a problem hiding this comment.
this is all code moved from physical_expr
| }; | ||
| } | ||
|
|
||
| #[cfg(test)] |
| Ok(make_array(data)) | ||
| } | ||
|
|
||
| #[macro_export] |
Contributor
Author
There was a problem hiding this comment.
this macro was unused from what I can tell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Inspired while working on #7126
Rationale for this change
the physical_expr module was getting large with several unrelated things like
AnalysisContextand a scatter functionWhat changes are included in this PR?
AnalysisContextand related functions into a new modulescatterintoutilsAre these changes tested?
Existing tests
Are there any user-facing changes?
I don't think so -- the paths have been updated and all existing code should work