Expose substrait protoc feature#5852
Merged
Merged
Conversation
mbrobbel
approved these changes
Apr 3, 2023
Member
Author
|
Here is the corresponding DataFusion Python PR: |
andygrove
added
the
development-process
yjshen
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The Python binding release workflow has been broken since we added substrait support, because the protoc compiler is not available in maturin-action / manylinux container.
What changes are included in this PR?
Expose substrait's protoc feature so we can remove the compile-time dependency on protoc.
Are these changes tested?
Not yet but I plan on creating a corresponding PR in the python repo
Are there any user-facing changes?