[haohuaijin]

Which issue does this PR close?

• Closes SortMergeJoin projection pushdown can reuse stale JoinFilter indices #24414.

Rationale for this change

Projection pushdown through SortMergeJoinExec could reuse stale join-filter indices and return incorrect results.

What changes are included in this PR?

• Rewrite the JoinFilter during projection pushdown.
• Reject the swap when a filter column cannot be mapped.
• Add an SQLLogicTest for the incorrect-result case.

Are these changes tested?

Yes. The SQLLogicTest verifies the physical plan and the expected (1, 1) result. The full Rust lint and extended workspace test suites also pass.

Are there any user-facing changes?

Affected queries now return correct results. There are no API changes.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.39%. Comparing base (5134a1a) to head (14a2891).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #24415      +/-   ##
==========================================
+ Coverage   81.38%   81.39%   +0.01%     
==========================================
  Files        1116     1116              
  Lines      397960   397973      +13     
  Branches   397960   397973      +13     
==========================================
+ Hits       323880   323935      +55     
+ Misses      55120    55075      -45     
- Partials    18960    18963       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kosiew]

@haohuaijin,

Thanks for working on this. The fix looks good to me. Remapping the join filter alongside the join keys addresses the stale column index issue, and the added unit and SQL regression coverage looks solid.

I left one optional suggestion for extending the SQL regression coverage.

[kosiew]

@haohuaijin,

Thanks for the follow-up. The latest change addresses the review comment nicely.

The new LEFT JOIN regression covers the important case where a potential match is rejected by the join filter, so the result correctly contains a null-extended right side even though the filter columns are projected away. The surrounding configuration uses prefer_hash_join = false, and the adjacent EXPLAIN already confirms this query shape goes through SortMergeJoinExec.

Looks good to me. Thanks for adding the focused regression!

[haohuaijin]

Thanks @kosiew