fix(proto): preserve Arrow IPC stream format - #24224
Open
buraksenn wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
proto
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24224 +/- ##
==========================================
- Coverage 80.99% 80.96% -0.03%
==========================================
Files 1106 1106
Lines 383158 383315 +157
Branches 383158 383315 +157
==========================================
+ Hits 310331 310367 +36
- Misses 54513 54626 +113
- Partials 18314 18322 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rich-T-kid
reviewed
Aug 10, 2026
Comment on lines
+1293
to
+1301
| enum ArrowIpcFormat { | ||
| // Unset in payloads encoded before this field existed; decoded as the | ||
| // IPC file format for backward compatibility. | ||
| ARROW_IPC_FORMAT_UNSPECIFIED = 0; | ||
| // Arrow IPC file format (with footer, supports range-based parallel reading) | ||
| ARROW_IPC_FORMAT_FILE = 1; | ||
| // Arrow IPC stream format (without footer, sequential reading only) | ||
| ARROW_IPC_FORMAT_STREAM = 2; | ||
| } |
Contributor
There was a problem hiding this comment.
if ARROW_IPC_FORMAT_UNSPECIFIED exist for the sake of backwards compatiability cant the default value be set to ARROW_IPC_FORMAT_FILE. this way we dont need a third variant especially since it will be interpreted as ARROW_IPC_FORMAT_FILE anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ArrowSourcedistinguishes between Arrow IPC file and stream formats, but this format was not serialized. As a result, a stream scan round-tripped through protobuf as a file scan, selecting the wrong opener and potentially allowing unsupported range-based repartitioning.What changes are included in this PR?
ArrowIpcFormatdiscriminator toArrowScanExecNode.ArrowSourceIPC format.Are these changes tested?
Yes:
cargo test -p datafusion-proto --test proto_integration roundtrip_arrowcargo test -p datafusion-proto --test proto_integration arrow_scan_without_format_field_decodes_as_file_formatcargo fmt --alldatafusion-datasource-arrowanddatafusion-protoAre there any user-facing changes?
Arrow IPC stream scans now preserve their format across protobuf round trips.
The binary protobuf change is additive. Older payloads continue to decode as file format. Stream preservation requires both producer and consumer to include this change because older versions do not carry or read the discriminator. The generated Rust
ArrowScanExecNodestruct gains aformatfield.