refactor(proto): migrate CsvSource serde - #24177
Merged
Merged
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24177 +/- ##
==========================================
- Coverage 81.06% 81.05% -0.01%
==========================================
Files 1107 1106 -1
Lines 382191 382209 +18
Branches 382191 382209 +18
==========================================
- Hits 309807 309803 -4
- Misses 54082 54094 +12
- Partials 18302 18312 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
adriangb
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Part of epic #23494. Moves
CsvSourceprotobuf serialization from the central dispatch into the source implementation.What changes are included in this PR?
Add protobuf serialization and deserialization to
CsvSource, including the CSV format options represented by the existing wire format.Repoint the live decode arm to
CsvSource::try_from_protoand remove the old central encode arm. Keeptry_into_csv_scan_physical_planas a deprecated compatibility wrapper that delegates to the new implementation.The protobuf wire format remains unchanged.
Are these changes tested?
Yes. Added
roundtrip_csv_scan_preserves_format_options, covering header, delimiter, quote, escape, comment, multiline values, and truncated rows.Are there any user-facing changes?
The existing
PhysicalPlanNodeExtmethod remains available as a deprecated compatibility wrapper. There is no immediate API removal or wire-format change.