Skip to content

refactor(proto): migrate ParquetSource serde - #24169

Merged
adriangb merged 4 commits into
apache:mainfrom
buraksenn:buraksen/23517-proto-parquet-source
Aug 8, 2026
Merged

refactor(proto): migrate ParquetSource serde#24169
adriangb merged 4 commits into
apache:mainfrom
buraksenn:buraksen/23517-proto-parquet-source

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Part of epic #23494. Moves ParquetSource protobuf serialization from central dispatch into the source implementation.

What changes are included in this PR?

Add protobuf serialization and deserialization to ParquetSource, including the pushdown predicate and TableParquetOptions. Rebuild the cached Parquet reader factory from the runtime environment during
deserialization.

Are these changes tested?

Yes. Existing Parquet round-trip tests cover this change.

Are there any user-facing changes?

no

@github-actions github-actions Bot added proto Related to proto crate datasource Changes to the datasource crate labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-datasource-parquet v54.1.0 (current)
       Built [  56.723s] (current)
     Parsing datafusion-datasource-parquet v54.1.0 (current)
      Parsed [   0.032s] (current)
    Building datafusion-datasource-parquet v54.1.0 (baseline)
       Built [  49.185s] (baseline)
     Parsing datafusion-datasource-parquet v54.1.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.156s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 107.523s] datafusion-datasource-parquet
    Building datafusion-proto v54.1.0 (current)
       Built [  60.305s] (current)
     Parsing datafusion-proto v54.1.0 (current)
      Parsed [   0.018s] (current)
    Building datafusion-proto v54.1.0 (baseline)
       Built [  60.611s] (baseline)
     Parsing datafusion-proto v54.1.0 (baseline)
      Parsed [   0.020s] (baseline)
    Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.259s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip

--- failure function_marked_deprecated: function #[deprecated] added ---

Description:
A function is now #[deprecated]. Downstream crates will get a compiler warning when using this function.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/function_marked_deprecated.ron

Failed in:
  function datafusion_proto::physical_plan::from_proto::parse_protobuf_file_scan_schema in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/from_proto.rs:432

--- failure trait_method_marked_deprecated: trait method #[deprecated] added ---

Description:
A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron

Failed in:
  method try_into_parquet_scan_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:1036

     Summary semver requires new minor version: 0 major and 2 minor checks failed
    Finished [ 122.372s] datafusion-proto

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Aug 7, 2026
@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.36782% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.05%. Comparing base (7d31a09) to head (db7521d).

Files with missing lines Patch % Lines
datafusion/datasource-parquet/src/source.rs 68.75% 13 Missing and 12 partials ⚠️
datafusion/proto/src/physical_plan/mod.rs 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24169      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.01%     
==========================================
  Files        1106     1106              
  Lines      382252   382272      +20     
  Branches   382252   382272      +20     
==========================================
- Hits       309856   309837      -19     
- Misses      54090    54120      +30     
- Partials    18306    18315       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
#[deprecated(
since = "55.0.0",
note = "unused by DataFusion; `ParquetSource::try_from_proto` parses the schema itself"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note = "unused by DataFusion; `ParquetSource::try_from_proto` parses the schema itself"
note = "unused by DataFusion"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something a bit more explanatory?

@adriangb
adriangb added this pull request to the merge queue Aug 8, 2026
Merged via the queue into apache:main with commit e440932 Aug 8, 2026
37 checks passed
@buraksenn
buraksenn deleted the buraksen/23517-proto-parquet-source branch August 8, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change datasource Changes to the datasource crate proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto: migrate ParquetSource

3 participants