refactor(proto): migrate window serde - #23780
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23780 +/- ##
==========================================
- Coverage 80.69% 80.65% -0.05%
==========================================
Files 1090 1091 +1
Lines 370357 370564 +207
Branches 370357 370564 +207
==========================================
+ Hits 298859 298860 +1
- Misses 53684 53870 +186
- Partials 17814 17834 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b398e8c to
7080910
Compare
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "proto")] |
There was a problem hiding this comment.
Could we put these under a mod proto here or as a file alongside this one?
|
One request: consider keeping the explanatory comments from #23496. The port strips them, and
|
Window plans still relied on centralized protobuf dispatch, keeping serialization separate from the execution plans that own their state. Both window executors share one protobuf variant. Decoding must inspect `input_order_mode` before selecting the concrete plan. Add plan-local encoders for both executors and a decoder for the shared node. Keep the legacy helpers as deprecated delegates while preserving window frames and UDF payloads on the existing wire format. CLOSES apache#23513 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
7080910 to
1c766ca
Compare
Done |
Window protobuf helpers obscured the execution plan implementations. Keeping them feature-gated together makes the shared serialization invariants easier to maintain without widening their visibility. Refs apache#23513 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
1c766ca to
6794927
Compare
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#23513. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Window plans still relied on centralized protobuf dispatch, keeping serialization separate from the execution plans that own their state. Both window executors share one protobuf variant. Decoding must inspect `input_order_mode` before selecting the concrete plan. Add plan-local encoders for both executors and a decoder for the shared node. Keep the legacy helpers as deprecated delegates while preserving window frames and UDF payloads on the existing wire format. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Which issue does this PR close?
Rationale for this change
Window plans still relied on centralized protobuf dispatch, keeping serialization separate from the execution plans that own their state. Both window executors share one protobuf variant. Decoding must inspect
input_order_modebefore selecting the concrete plan.Add plan-local encoders for both executors and a decoder for the shared node. Keep the legacy helpers as deprecated delegates while preserving window frames and UDF payloads on the existing wire format.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?