fix: order by expr rewrite fix - #14486
Merged
Merged
Conversation
github-actions
Bot
added
sql
akoshchiy
marked this pull request as ready for review
February 5, 2025 18:48
Contributor
|
I checked the newly added tests and they were failing before 👍🏻 |
berkaysynnada
approved these changes
Feb 6, 2025
berkaysynnada
left a comment
berkaysynnada
left a comment
Contributor
There was a problem hiding this comment.
Thank you @akoshchiy, the fix is LGTM.
comphead
approved these changes
Feb 6, 2025
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @akoshchiy
Double checked the similar query works in duckDB
D select a from (select 1 a, 2 b) group by a order by sum(b);
┌───────┐
│ a │
│ int32 │
├───────┤
│ 1 │
└───────┘
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14459.
What changes are included in this PR?
Added the search for a columnized expressions in the children projection nodes.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.