Skip to content

build(ci): use proper mac runners #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 3 commits into from
Sep 2, 2024
Merged

build(ci): use proper mac runners #841

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4893fe6
build(ci): use proper mac runners
Michael-J-Ward Aug 26, 2024
700a28a
update name for macos x86_64 build job
Michael-J-Ward Aug 26, 2024
cb6efbe
update manylinux x86_64 job name for consistency
Michael-J-Ward Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ jobs:
name: dist-${{ matrix.os }}
path: target/wheels/*

build-macos-aarch64:
build-macos-x86_64:
needs: [generate-license]
name: Mac arm64
runs-on: macos-latest
name: Mac x86_64
runs-on: macos-13
strategy:
fail-fast: false
matrix:
Expand All @@ -134,9 +134,6 @@ jobs:
with:
toolchain: stable

- name: Set up Rust targets
run: rustup target add aarch64-apple-darwin

- name: Upgrade pip
run: python -m pip install --upgrade pip

Expand All @@ -157,7 +154,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Build Python package
run: maturin build --release --strip --target aarch64-apple-darwin --features substrait
run: maturin build --release --strip --features substrait
- name: List Mac wheels
run: find target/wheels/

Expand All @@ -169,7 +166,7 @@ jobs:

build-manylinux-x86_64:
needs: [generate-license]
name: Manylinux
name: Manylinux x86_64
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -260,7 +257,7 @@ jobs:
runs-on: ubuntu-latest
needs:
- build-python-mac-win
- build-macos-aarch64
- build-macos-x86_64
- build-manylinux-x86_64
- build-manylinux-aarch64
- build-sdist
Expand Down