Skip to content

Remove libprotobuf dep#527

Merged
andygrove merged 7 commits into
apache:mainfrom
jdye64:remove_libprotobuf_dep
Oct 26, 2023
Merged

Remove libprotobuf dep#527
andygrove merged 7 commits into
apache:mainfrom
jdye64:remove_libprotobuf_dep

Conversation

@jdye64
Copy link
Copy Markdown
Contributor

@jdye64 jdye64 commented Oct 26, 2023

Which issue does this PR close?

Closes #526

Comment thread src/lib.rs
Comment thread conda/recipes/meta.yaml
@andygrove andygrove merged commit da6c183 into apache:main Oct 26, 2023
@jorisvandenbossche
Copy link
Copy Markdown
Member

With datafusion-substrait now being an optional feature, that also means that the datafusion python wheels will no longer include substrait support? Is there a way to still install it with pip?

@jdye64
Copy link
Copy Markdown
Contributor Author

jdye64 commented Dec 1, 2023

With datafusion-substrait now being an optional feature, that also means that the datafusion python wheels will no longer include substrait support? Is there a way to still install it with pip?

This is a good point I had not considered. Seems like we need to make sure at release time to specify that feature should be included. I think it is fine to always include substrait in the python wheels. I think the problem was mostly for 3rd party applications that are using ADP more like an SDK. Not sure on Andy's process for a release. @andygrove is there something I might need to commit/file change to enable that for each release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Substrait Rust Feature

4 participants