feat: add case function (#447)#448
Merged
Merged
Conversation
alamb
approved these changes
Aug 4, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I don't know all that much about this code so I defer to @andygrove and @jdye64 but this looks good to me and is well tested
Thank you @mesejo
Contributor
|
Looks like there is one failing CI check |
Contributor
|
Yes, @mesejo there is a check-style test failing if you don't mind fixing. If not I can make the commit to resolve |
mesejo
force-pushed
the
feat/add-case-function
branch
from
b10b21b to
600ef93
Compare
Contributor
Author
Contributor
|
Thanks again @mesejo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #447
What changes are included in this PR?
Besides exposing the case function, this PR also adds the PyCaseBuilder class (to parallel Rust's CaseBuilder)
Are there any user-facing changes?
Yes, but the documentation should be generated automatically