Skip to content

Add 'pub' and '#[pyo3(get, set)]' to DataTypeMap #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 2 commits into from
May 5, 2023
Merged

Add 'pub' and '#[pyo3(get, set)]' to DataTypeMap #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30e0d43
Add and to DataTypeMap
jdye64 May 4, 2023
011e838
Add PyDataType as pub
jdye64 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/common/data_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ use crate::errors::py_datafusion_err;
#[derive(Debug, Clone)]
#[pyclass(name = "DataTypeMap", module = "datafusion.common", subclass)]
pub struct DataTypeMap {
#[allow(dead_code)]
arrow_type: PyDataType,
#[allow(dead_code)]
python_type: PythonType,
#[allow(dead_code)]
sql_type: SqlType,
#[pyo3(get, set)]
pub arrow_type: PyDataType,
#[pyo3(get, set)]
pub python_type: PythonType,
#[pyo3(get, set)]
pub sql_type: SqlType,
}

impl DataTypeMap {
Expand Down Expand Up @@ -421,7 +421,7 @@ impl DataTypeMap {
#[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
#[pyclass(name = "DataType", module = "datafusion.common")]
pub struct PyDataType {
data_type: DataType,
pub data_type: DataType,
}

impl From<PyDataType> for DataType {
Expand Down