Add interface to serialize Substrait plans to Python Bytes.#344
Merged
Conversation
Clean up existing substrait bindings to return bytes instead of List[int].
kdbrooks
changed the title
jdye64
approved these changes
Apr 25, 2023
Contributor
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
@kylebrooks-8451 thank you for this. Can't believe we missed this the first go around. LGTM. Thanks!
andygrove
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, Clean up existing Substrait bindings to return bytes instead of List[int].
Which issue does this PR close?
Closes #343
Rationale for this change
What we had before didn't allow for serializing a Substrait plan to ProtoBuf. You had to use a SQL query which was awkward. This also fixes the
substraitmodule return types to bebytesinstead ofList[int]which is also awkward.What changes are included in this PR?
Add
encodemethod todatafusion.substrait.plan. Also change datafusion.substrait return types to bebytesinstead ofList[int].Are there any user-facing changes?
Yes, but IMO changes for the better.