feature: Set table name from ctx functions#260
Merged
andygrove merged 2 commits intoMar 7, 2023
Conversation
simicd
force-pushed
the
feature/table-name-in-from-ctx-functions
branch
from
908d457 to
c23c940
Compare
jdye64
approved these changes
Mar 7, 2023
Contributor
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
LGTM. Very handy addition
| .simple() | ||
| .encode_lower(&mut Uuid::encode_buffer()); | ||
| let table_name = match name { | ||
| Some(val) => val.to_owned(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #259
Rationale for this change
Possibility to set table name when constructing dataframe from Arrow table/Python dictionary/pandas/polars
What changes are included in this PR?
See above
Are there any user-facing changes?
Optional
nameparameter increate_dataframeandfrom_functions