fix: support map casts with NullType elements - #5045
Merged
Conversation
peterxcli
marked this pull request as ready for review
July 27, 2026 06:02
Member
Author
|
cc @comphead PTAL. Thanks! |
sunchao
approved these changes
Aug 23, 2026
sunchao
left a comment
sunchao
left a comment
Member
There was a problem hiding this comment.
Reviewed the NullType compatibility change against Spark's cast rules and Comet's recursive native map cast path. I found no P1/P2 issues. The native NullType conversion produces correctly typed null arrays, and the SQL test changes require native execution for the supported map casts.
Exact-head CI passed. I did not run the full test matrix locally.
Member
|
Merged, thanks @peterxcli ! |
Member
Author
|
Thanks @sunchao ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3389.
Rationale for this change
The native cast path supports
NullArraycasts, but the planner rejectedNullTypemap elements before they reached it.What changes are included in this PR?
NullTypecasts as compatible with native execution.map_contains_keycases.How are these changes tested?
make core./mvnw test -Pjdk17 -Dtest=none -Dsuites='org.apache.comet.CometSqlFileTestSuite map_contains_key.sql'