Repository navigation
chore: move CometCollationSuite to spark-4.1+ test shim - #4864
Merged
andygrove merged 4 commits intoOct 8, 2026
Merged
Conversation
Member
|
CI didn't run .... |
Contributor
Author
|
Thanks @andygrove |
Member
|
@0lai0 could you rebase this PR? |
0lai0
force-pushed
the
chore-4770-comet-collation-suite-4.1+
branch
from
September 10, 2026 03:26
2fd4856 to
74e2a13
Compare
Contributor
Author
|
Rebased onto latest main |
Contributor
andygrove
enabled auto-merge
October 8, 2026 15:42
…llation-suite-4.1+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4770
Rationale for this change
CometCollationSuitecurrently lives in thespark-4.1test shim, but the same tests apply to Spark 4.2+. Moving it tospark-4.1+and enabling that test shim avoids duplicating the suite per Spark minor version.What changes are included in this PR?
spark/pom.xml: addsrc/test/${shims.minorPlusVerSrc}to theadd-test-sourceexecution so thespark-4.1+test shim is compiled.CometCollationSuite.scalafromspark/src/test/spark-4.1/tospark/src/test/spark-4.1+/(content unchanged).How are these changes tested?