Skip to content

minor: Add RDDScan to default value of sparkToColumnar.supportedOperatorList - #2422

Merged
mbutrovich merged 1 commit into
apache:mainfrom
wForget:minor2
Sep 20, 2025
Merged

mbutrovich merged 1 commit into
apache:mainfrom
wForget:minor2

Conversation

@wForget

@wForget wForget commented Sep 19, 2025

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #.

Rationale for this change

To make it easier for us to write test cases for comet expressions like #2410.

What changes are included in this PR?

How are these changes tested?

This test case ran successfully:

  test("test array literal") {
    withSQLConf(
      CometConf.COMET_SPARK_TO_ARROW_ENABLED.key -> "true",
      SQLConf.OPTIMIZER_EXCLUDED_RULES.key -> "org.apache.spark.sql.catalyst.optimizer.ConstantFolding") {
      checkSparkAnswerAndOperator("select array('1', '2', '3')")
    }
  }

@codecov-commenter

codecov-commenter commented Sep 19, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.84%. Comparing base (f09f8af) to head (a362046).
⚠️ Report is 1166 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2422      +/-   ##
============================================
+ Coverage     56.12%   57.84%   +1.71%     
- Complexity      976     1401     +425     
============================================
  Files           119      147      +28     
  Lines         11743    13469    +1726     
  Branches       2251     2341      +90     
============================================
+ Hits           6591     7791    +1200     
- Misses         4012     4446     +434     
- Partials       1140     1232      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cfmcgrady

Copy link
Copy Markdown
Contributor

A cheaper approach than the one I took on my dev branch (where I implemented a JVM-based CometOneRowRelation for native OneRowRelation scans).

@andygrove
andygrove requested a review from comphead September 19, 2025 14:36

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @wForget

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wForget
@cfmcgrady do you feel it closes #2410 ?

@mbutrovich
mbutrovich merged commit 547fbe8 into apache:main Sep 20, 2025
96 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
@andygrove andygrove mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants