Repository navigation
docs: Update "Adding a New Expression" to reference SQL file tests #3406
Description
Activity
#3598 (84df1ce) added this. docs/source/contributor-guide/adding_a_new_expression.md now has a "Writing a Comet SQL Test" section that walks through creating a
.sqlfixture under spark/src/test/resources/sql-tests/expressions/, links to the Comet SQL Tests guide for the full format, and presents the ScalaCometExpressionSuiteroute as the exception for cases SQL files cannot express. Suggest closing.Gentle ping: still holds on current main. #3598 added a section on SQL file tests to the Adding a New Expression guide (now titled "Writing a Comet SQL Test"). OK to close?
What is the problem the feature request solves?
We've had a number of recent PRs adding new expressions (which is phenomenal!) that I have to ask to add/migrate tests to the new SQL file test framework (https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html).
Describe the potential solution
Add a link to SQL file tests https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html on the "Adding a New Expression" page and mention it in how to test.
https://datafusion.apache.org/comet/contributor-guide/adding_a_new_expression.html
Additional context
No response