Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on the reported failed reopen during rotation.
If opening the replacement throws
FileNotFoundException, the existing try-with-resources closes the old reader. Subsequent reads may then terminate the tailer. Keeping that reader open alone is insufficient when the replacement grows past the previous position before the next poll.This patch opens the replacement before closing the old reader and retains
rotationPendinguntil reopening succeeds. Remaining old-file lines are read after the replacement opens. It does not fix the separate periodicreOpenfailure path described in IO-399.Validation on base
f720b24227eb6972d4281d330ddb64c1416f81a4:PathUtilsCopyTestsymlink privilege errors reproduce on the unmodified base. This is not a claim that the full test suite passes.Submitted following the maintainer's suggestion to provide a PR with a failing test. A Jira association can be added as needed.