Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR updates the alert id for VR public and private interface (with alert names - ALERT.VR.PUBLIC.IFACE.MTU and ALERT.VR.PRIVATE.IFACE.MTU) to 33 and 34 respectively. Both were using same id (32) as ALERT.VM.SNAPSHOT.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr and others added 2 commits January 27, 2026 17:56
ALERT.VM.SNAPSHOT, ALERT.VR.PUBLIC.IFACE.MTU and
ALERT.VR.PRIVATE.IFACE.MTU are all having type value 32.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (af9d686) to head (f604b79).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/event/AlertGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12527      +/-   ##
============================================
- Coverage     16.24%   16.24%   -0.01%     
+ Complexity    13397    13395       -2     
============================================
  Files          5658     5658              
  Lines        499273   499273              
  Branches      60600    60600              
============================================
- Hits          81103    81101       -2     
- Misses       409127   409129       +2     
  Partials       9043     9043              
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.10% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16567

@DaanHoogland
Copy link
Contributor

This will need an upgrade test mainly, the core functionality has been tested by GHA.

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM.

@apache apache deleted a comment from Damans227 Jan 27, 2026
@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants