Make gp_matview_aux and gp_matview_tables unshared catalog.#756
Merged
my-ship-it merged 2 commits intoapache:mainfrom Dec 6, 2024
Merged
Make gp_matview_aux and gp_matview_tables unshared catalog.#756my-ship-it merged 2 commits intoapache:mainfrom
my-ship-it merged 2 commits intoapache:mainfrom
Conversation
There is no need to share those across databases. One only need to know its own matview status. Authored-by: Zhang Mingli avamingli@gmail.com
Contributor
|
We need to bump catversion here. |
Contributor
Author
Good suggestion, will do. Seems other PRs have a catalog change should do this too, ex: #725 |
Contributor
Author
Fixed. |
reshke
approved these changes
Dec 5, 2024
my-ship-it
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A question raised by @reshke in #582
And I get clear answer from @gfphoenix78 when a catalog should be shared or not.
AFATK, there is no need to share those across databases.
One only need to know its own matview status.
Authored-by: Zhang Mingli avamingli@gmail.com
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions