Fix #6840: stop passing a Printf arg to the structured digest log - #6842
Merged
Merged
Conversation
squakez
approved these changes
Sep 23, 2026
Contributor
|
|
Contributor
Author
|
@squakez ig no issues, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6840
Logger.Infotakes key-value pairs, not a format string —Infofis the Printf variant. The digest-changed log inbuild_kit.gopassed"...%s...", integration.NametoInfo, so zap saw a key with no value and raiseddpanic, and the%snever interpolated.Dropped the argument rather than switching to
Infof: the action's logger is built byrlog.ForIntegration(target), sonsandnameare already on every record.Checked the rest of the repo with an AST pass over all
Info/Debug/Errorcall sites — this was the only parity violation. Existing tests already cover this branch.