Conversation
Both flags were deprecated in v2.9.0. Removes the flags, the runCmdOptions fields behind them, and the code that existed only to serve them: syncIntegration, filterFileLocation, the pkg/util/sync package and DeleteIntegration. --logs and --wait keep their current behaviour.
squakez
reviewed
Sep 19, 2026
squakez
left a comment
Contributor
There was a problem hiding this comment.
Cool cleaning work. Thanks. A few comments to verify.
Contributor
|
✔️ Unit test coverage report - coverage increased from 63.9% to 64.2% (+0.3%) |
… dependency The dependencies.adoc sentence only made sense in terms of the dev loop, so remove it rather than reword it. pkg/util/sync was the only first-party user of fsnotify, so go mod tidy moves it to the indirect block, where viper still needs it.
squakez
approved these changes
Sep 20, 2026
Contributor
|
✔️ Unit test coverage report - coverage increased from 63.8% to 64.2% (+0.4%) |
Contributor
|
Please, |
syncIntegration held the only call to RootCmdOptions.ContextCancel, so the cancel func from WithCancel was left uncalled (gosec G118). The child context existed only to let sync cancel and restart the in-flight command, so drop it along with RootContext, which had a single use. Realign the runCmdOptions tags the removed fields left ragged.
Author
|
Both lint issues fixed, and both turned out to be fallout from the removal rather than formatting noise:
No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6829
kamel run --devand--syncwere deprecated in v2.9.0 and printed a removal notice on every use. This removes them, sokamel runno longer carries a file-watching rebuild loop that nothing else in the CLI depends on.What is removed
--devand--syncflags and theDev/Syncfields onrunCmdOptions.--dev+-o/--outputmutual-exclusion check and the "Dev and Sync properties are deprecated" notice invalidate.run: the SIGTERM handler that deleted the Integration on Ctrl-C, and theo.Dev/o.Syncarms of the--logsand--waitconditions.syncIntegration, plus what only it used:filterFileLocation(run_support.go), thepkg/util/syncpackage, andDeleteIntegration(pkg/cmd/util.go). The e2e suite has its ownDeleteIntegrationsine2e/support, so nothing else calls it.TestFilterFileLocation.--logsand--waitbehave exactly as before: the twoif o.Logsbranches left after theo.Devarms were dropped are merged into one, which is the same sequence of calls in the same order.No deprecation shim is added — Cobra already answers
--devwithunknown flag: --dev, matching how #6816 left the removed subcommands. Following your reviews on #6807 and #6816, there is also no test asserting the flags are gone.The only mention left in
docs/was a passing "dev mode" aside inconfiguration/dependencies.adoc; it is reworded rather than deleted, since the point it makes about automatic dependency resolution still holds.Testing
go build ./pkg/... ./cmd/...,go vet ./pkg/cmd/... ./pkg/util/...andgofmt -lare clean, andgo test ./pkg/cmd/...shows the same 10 pre-existing Windows-only path/file-lock failures before and after the change. Built./cmd/kameland confirmed--devand--syncare gone fromrun --helpand now reportunknown flag.