Skip to content

feat(trait): Support owner trait wildcard - #6734

Merged
squakez merged 6 commits into
apache:mainfrom
subhramit:fix-6497-owner-trait-wildcard
Aug 3, 2026
Merged

squakez merged 6 commits into
apache:mainfrom
subhramit:fix-6497-owner-trait-wildcard

Conversation

@subhramit

@subhramit subhramit commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes #6497

Add * support to the owner trait so users can propagate all integration labels and/or annotations to owned resources.

  • owner.target-labels=* copies all integration labels
  • owner.target-annotations=* copies all integration annotations

Tests

Added relevant unit tests.
ran

  • make fmt
  • make lint
  • go test ./pkg/trait -run TestOwner -count=1
  • make generate
  • make update-docs

Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: Subhramit Basu <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Comment thread docs/modules/ROOT/partials/apis/camel-k-crds.adoc
Signed-off-by: Subhramit Basu <subhramit.bb@live.in>
This reverts commit eade330.

Signed-off-by: Subhramit Basu <subhramit.bb@live.in>
@subhramit subhramit changed the title Fix #6497: Support owner trait wildcard feat(trait): Support owner trait wildcard Jul 31, 2026
Comment thread pkg/trait/owner.go
@subhramit

Copy link
Copy Markdown
Contributor Author

@squakez I assume the kafka and knative tests are flaky/unrelated? Kafka seems to have timed out, while knative had pretty verbose logs so I used copilot's "explain error". It said

the in-cluster/local registry at 10.105.152.199 is not reachable with the default secure settings (HTTPS + auth) used by the image builder. The image build is therefore failing and the test stops.

Comment thread pkg/trait/owner.go
@subhramit

Copy link
Copy Markdown
Contributor Author

@squakez I assume the kafka and knative tests are flaky/unrelated? Kafka seems to have timed out, while knative had pretty verbose logs so I used copilot's "explain error". It said

the in-cluster/local registry at 10.105.152.199 is not reachable with the default secure settings (HTTPS + auth) used by the image builder. The image build is therefore failing and the test stops.

Okay, knative passed on this run.

@squakez
squakez merged commit d9eb979 into apache:main Aug 3, 2026
12 of 14 checks passed
@squakez

squakez commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Nice work, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Owner trait: add all labels and annotations

2 participants