Skip to content

fix(ctrl): knative service watch rbac #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squakez merged 1 commit into from
Jun 4, 2026
Merged

fix(ctrl): knative service watch rbac #6658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/controller/integration/integration_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,9 @@ func watchKnativeResources(ctx context.Context, c client.Client, b *builder.Buil
return err
}
if !ok {
log.Info(`KnativeService resources are not installed in the cluster. You can't use Knative features. If you install Knative Serving resources after the
Camel K operator, make sure to apply the required RBAC privileges and restart the Camel K Operator Pod to be able to watch for
Camel K managed Knative Services.`)
log.Info("KnativeService resources are not installed in the cluster. You can't use Knative serving features. " +
"If you install Knative Serving resources after the Camel K operator, make sure to apply the required RBAC privileges " +
"and restart the Camel K Operator Pod to be able to watch for Camel K managed Knative Services.")

return nil
}
Expand All @@ -448,11 +448,12 @@ func watchKnativeResources(ctx context.Context, c client.Client, b *builder.Buil
if ok, err = kubernetes.CheckSelfPermission(checkCtx, c, serving.GroupName, "services", platform.GetOperatorWatchNamespace(), "", "watch"); err != nil {
return err
} else if ok {
log.Info("KnativeService resources installed in the cluster. RBAC privileges assigned correctly, you can use Knative features.")
log.Info("KnativeService resources installed in the cluster. RBAC privileges assigned correctly, you can use Knative serving features.")
b.Owns(&servingv1.Service{}, builder.WithPredicates(StatusChangedPredicate{}))
} else {
log.Info(` KnativeService resources installed in the cluster. However Camel K operator has not the required RBAC privileges. You can't use Knative features.
Make sure to apply the required RBAC privileges and restart the Camel K Operator Pod to be able to watch for Camel K managed Knative Services.`)
log.Info("KnativeService resources installed in the cluster. However Camel K operator has not the required RBAC privileges. " +
"You can't use Knative features.Make sure to apply the required RBAC privileges and restart the Camel K Operator Pod to be able " +
"to watch for Camel K managed Knative Services.")
}

return nil
Expand Down
4 changes: 1 addition & 3 deletions pkg/resources/config/rbac/descoped/operator-cluster-role-knative.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ rules:
- get
- list
- patch
# - update
# - watch
- watch
- apiGroups:
- eventing.knative.dev
resources:
Expand All @@ -46,7 +45,6 @@ rules:
- get
- list
- patch
# - update
- apiGroups:
- messaging.knative.dev
resources:
Expand Down
1 change: 1 addition & 0 deletions pkg/resources/config/rbac/namespaced/operator-role-knative.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ rules:
- get
- list
- patch
- watch
- apiGroups:
- eventing.knative.dev
resources:
Expand Down
Loading