Repository navigation
Conversation
…erializablePackagePath is not set
Since CALCITE-7787 a model may set pdxSerializablePackagePath only when
calcite.geode.pdxSerializablePackagePath.allowed is true, so a default
deployment leaves it out. GeodeUtils.createClientCache passed the absent
operand to new ReflectionBasedAutoSerializer(String...), which reads it
as a class pattern, and creating a schema with a new client cache failed
in both Geode schema factories:
java.lang.NullPointerException: Cannot invoke "String.split(String)" because "value" is null
createClientCache now creates a serializer with no class pattern when the
operand is absent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
rubenada
approved these changes
Oct 14, 2026
Contributor
|
Thanks for catching this @vlsi ! This was my mistake on the original ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: CALCITE-7852
Since CALCITE-7787, a model may set
pdxSerializablePackagePathonly whencalcite.geode.pdxSerializablePackagePath.allowedistrue, so a default deployment leaves the operand out. Creating a schema with a new client cache then fails in bothGeodeSchemaFactoryandGeodeSimpleSchemaFactory, becauseGeodeUtils.createClientCachepasses the absent operand tonew ReflectionBasedAutoSerializer(String...):With the operand absent,
createClientCachenow creates aReflectionBasedAutoSerializerwith no class pattern.Two new tests in
GeodeSchemaFactoryTest, one per factory, create the schema without the operand after closing the client cache; both fail on main with the exception above.The same fix was first made inside #5213 (CALCITE-7736), which now leaves
createClientCacheas main has it, so the two pull requests touchGeodeUtilsindependently.🤖 Generated with Claude Code