Repository navigation
Conversation
…query shapes Propagate FilterRequirement in SetOps and DelegatingNamespace
|
xuzifu666
reviewed
Sep 19, 2026
| sameIdentifier_.forEach(remnantMustFilterFields::remove); | ||
| // Clear the remnant must-filter qualifieds imported through the | ||
| // same FROM item (namespace) as the filtered bypass field | ||
| if (qualified.namespace != null) { |
Member
There was a problem hiding this comment.
Could it be that, within the same subquery, a bypass for one table incorrectly clears the remnant of another?
Contributor
Author
There was a problem hiding this comment.
Not sure I understand, could you please provide an example?
| final SqlValidatorNamespace operandNamespace = | ||
| requireNonNull(validator.getNamespace(operand), | ||
| () -> "namespace for " + operand); | ||
| final FilterRequirement requirement = operandNamespace.getFilterRequirement(); |
Member
There was a problem hiding this comment.
Here, one might need to consider that cross-bypass fields spanning set operation operands could result in valid queries being rejected.
Contributor
Author
There was a problem hiding this comment.
Do you mean something like
// Only operands that still owe a must-filter constrain the setop's bypass set
if (!requirement.filterFields.isEmpty() || !requirement.remnantFilterFields.isEmpty()) {
bypassFields = bypassFields == null
? requirement.bypassFields
: bypassFields.intersect(requirement.bypassFields);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7795
Changes Proposed
Correct certain query shapes (set-ops, alias-with-column-list, PIVOT/UNPIVOT/MATCH_RECOGNIZE/table functions, subqueries, INSERT/UPDATE/MERGE sources, cross-scope bypass purge) that silently drop or defuse the FilterRequirement.