FlakyTest: testEmptyLedgerLosesQuorumEventually#4672
Open
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
Open
FlakyTest: testEmptyLedgerLosesQuorumEventually#4672liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test by standardizing timeout values in the testEmptyLedgerLosesQuorumEventually test method. The changes align all assertion timeouts to 20 seconds to prevent test failures due to timing inconsistencies.
- Increased timeout values from 5 and 15 seconds to a consistent 20 seconds
- Standardized timeout duration across multiple assertions within the same test
- Addressed flaky test behavior identified in CI builds
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lhotari
approved these changes
Oct 15, 2025
Contributor
Author
|
/bkbot rerun |
Contributor
Author
|
reopen due to #4665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix flaky test: https://github.com/apache/bookkeeper/actions/runs/18525197327/job/52795009929?pr=4652
Changes
To maintain consistency and reduce future modifications, all assertion timeouts in
testEmptyLedgerLosesQuorumEventuallythat use the formatassertTrue(xxx, latch.await(xx))have been unified to 20 seconds.These assertion timeouts in this test have been changed several times, with each change only increasing the timeout of one assertion. To avoid repeated modifications in the future, these timeouts in this test have been aligned to the longest timeout value that was previously set.
bookkeeper/bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/BookieAutoRecoveryTest.java
Line 418 in bde9ff2