Repository navigation
BP-41 Separate BookieId from Bookie Network Address - #2397
Merged
Merged
Conversation
rdhabalia
approved these changes
Aug 11, 2020
rdhabalia
left a comment
rdhabalia
left a comment
Contributor
There was a problem hiding this comment.
this feature will be helpful. 👍
Contributor
Author
|
@fpj @sijie @ivankelly @jvrao It would be useful to have your opinion as you did for BP-38. This is a major change in BK APIs and internals the more are on it the better will be |
Contributor
Author
Thank you @rdhabalia |
sijie
approved these changes
Aug 13, 2020
sijie
left a comment
sijie
left a comment
Member
There was a problem hiding this comment.
The change looks good to me. +1
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Oct 6, 2020
This is the design document of "BP-41 Separate BookieId from Bookie Network Address" Master Issue: apache#2396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the design document of "BP-41 Separate BookieId from Bookie Network Address"
Master Issue: #2396