[Python] Add take(n) convenience for PCollection#37470
[Python] Add take(n) convenience for PCollection#37470jrmccluskey merged 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello @shaheeramjad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam Python SDK by introducing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
* Add Take transform and take() in transforms/util.py * Add PCollection.take(n) in pvalue.py * Add TakeTest in util_test.py * Update CHANGES.md Fixes apache#37429
f915d13 to
eb6df58
Compare
|
HI @damccorm, |
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
I'll defer this one to Jack as the assigned reviewer - thanks |
|
Thanks @shaheeramjad for the initiative.
This is misleading since PCollections are inherently unordered and distributed. There is no concept of "first X" elements in a pcollection.
this syntax is not typical for Beam python; i wouldn't introduce it without a discussion on dev mailing list (dev@beam.apache.org)
I'd like to request we revert this PR until further discussion happens. Thanks! |
Adds
take(n)convenience for PCollection: get the first N elements deterministically without usingTop.Of+FlatMapmanually.Changes
Taketransform andtake(n)function (uses Top.Of + FlatMap internally).PCollection.take(n)method.TakeTest(function/method syntax, edge cases, invalid n).Usage
Function syntax
first_10 = pcoll | beam.take(10)
Method syntax
first_10 = pcoll.take(10)
Fixes #37429
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)