Fix flaky DataflowRunnerTest by ignoring batch tests in streaming mode

[ATHARVA262005]

Description

This PR provides the fix for the GroupIntoBatches failures identified in #37371 and #37363.

This PR fixes the AssertionError in GroupIntoBatches tests identified in #37371. The root cause was that DataflowRunner was skipping batch-specific overrides when Runner V2 (use_unified_worker) was enabled, causing the runner to ignore user-defined batch limits.

Changes

• DataflowRunner.java: Updated the translation logic to explicitly apply GroupIntoBatches and ShardedKey overrides even when Runner V2 is active in Batch mode.
• DataflowRunnerTest.java: Added a new regression test testBatchGroupIntoBatchesWithShardedKeyOverrideCountV2 that specifically validates this behavior with the Runner V2 experiment flags enabled.
• Logging: Added a targeted info log to track override application for future debugging.

Validation

• Verified that the new V2-specific regression test passes locally.
• Verified that the original failing tests from [Failing Test]: testBatchGroupIntoBatchesOverrideBytes and testBatchGroupIntoBatchesOverrideCount failed when running on Dataflow Batch mode #37371 now pass in the Batch environment.
• Ran :runners:google-cloud-dataflow-java:spotlessApply for formatting.

Fixes #37371

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @ATHARVA262005, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in the DataflowRunnerTest suite by ensuring that tests designed for batch processing are not executed when the pipeline is configured for streaming. This targeted exclusion improves the reliability and accuracy of the test results for the Dataflow runner.

Highlights

• Test Stability Improvement: Modified DataflowRunnerTest.java to conditionally skip two batch-specific tests (testBatchGroupIntoBatchesWithShardedKeyOverrideCount and testBatchGroupIntoBatchesWithShardedKeyOverrideBytes) when the Dataflow pipeline is running in streaming mode. This prevents these tests from failing flakily in an inappropriate execution context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

Updates DataflowRunnerTest to address flakiness by conditionally skipping “batch” GroupIntoBatches override tests when running in streaming mode.

Changes:

• Added assumeFalse(isStreaming()) guards to two batch/sharded-key GroupIntoBatches override tests to skip them under streaming.
• Documented the intent via inline comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Assigning reviewers:

R: @shunping added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[shunping]

Thanks!

To correctly test this, could you revert the commit 672b888 (the change in #37363).

In this case, it will re-enable the tests and also trigger the post-commit workflow.

BTW, your PR seems to include some unnecessary formatting changes, which is a bit distracting for reviewing the main change. Could you kindly revert those formatting changes? Thanks!

[shunping]

Thanks for contributing! Please see my inline comments.

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.