Add Datadog IO#37319
Merged
Abacn merged 9 commits intoapache:masterfrom Jan 21, 2026
Merged
Conversation
derrickaw
force-pushed
the
addDatadogIO
branch
from
b74daae to
b2ed9dd
Compare
Collaborator
Author
|
Run Java_GCP_IO_Direct PreCommit |
Contributor
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
reviewed
Jan 16, 2026
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Thanks, left a few comments
| implementation library.java.google_http_client | ||
| implementation library.java.google_code_gson | ||
| implementation library.java.auto_value_annotations | ||
| annotationProcessor library.java.auto_value |
Contributor
There was a problem hiding this comment.
This should already be handled by BeamModulePlugin:
and not needed here
| activemq_mqtt : "org.apache.activemq:activemq-mqtt:$activemq_version", | ||
| args4j : "args4j:args4j:2.33", | ||
| auto_value_annotations : "com.google.auto.value:auto-value-annotations:$autovalue_version", | ||
| auto_value : "com.google.auto.value:auto-value:$autovalue_version", |
Contributor
There was a problem hiding this comment.
see below, this isn't needed
| import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| import com.google.auto.value.AutoValue; | ||
| import javax.annotation.Nullable; |
Contributor
There was a problem hiding this comment.
Prefer to use checkframework Nullable
Contributor
|
As a follow up, after Beam 2.72.0 gets released we can update Beam website: https://beam.apache.org/documentation/io/connectors/ |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #37318
Ported from here and here.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.