[AURON #1996] Standardize Cargo workspace edition and resolver configuration.#1997
Open
slfan1989 wants to merge 1 commit intoapache:masterfrom
Open
[AURON #1996] Standardize Cargo workspace edition and resolver configuration.#1997slfan1989 wants to merge 1 commit intoapache:masterfrom
slfan1989 wants to merge 1 commit intoapache:masterfrom
Conversation
slfan1989
changed the title
slfan1989
force-pushed
the
auron-1996
branch
from
bc6a9f0 to
a89b52a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the Cargo workspace configuration by centralizing edition and resolver settings, fixing incorrect resolver declarations in individual crates, and upgrading to resolver version 2 for improved dependency resolution.
Changes:
- Added
resolver = "2"and[workspace.package]withedition = "2024"to root Cargo.toml - Updated all 8 workspace member crates to inherit edition using
edition.workspace = true - Removed invalid
resolver = "1"declarations from 6 individual crate manifests (resolver should only be at workspace level)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added workspace-level resolver 2 and centralized edition configuration |
| native-engine/datafusion-ext-plans/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
| native-engine/datafusion-ext-functions/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
| native-engine/datafusion-ext-exprs/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
| native-engine/datafusion-ext-commons/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
| native-engine/auron/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
| native-engine/auron-planner/Cargo.toml | Removed duplicate edition, now inherits from workspace |
| native-engine/auron-memmgr/Cargo.toml | Removed duplicate edition, now inherits from workspace |
| native-engine/auron-jni-bridge/Cargo.toml | Removed duplicate edition and invalid resolver, now inherits from workspace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…configuration. Signed-off-by: slfan1989 <slfan1989@apache.org>
slfan1989
force-pushed
the
auron-1996
branch
from
d5005e3 to
1a2e9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1996
Rationale for this change
Standardize the Cargo workspace configuration to ensure consistent dependency resolution and edition settings across all crates.
This change:
Resolver 2 is the default resolver for Rust 2021 edition and provides improved dependency version resolution strategy.
What changes are included in this PR?
resolver = "2"to the workspace configuration[workspace.package]section with unifiededition = "2024"edition.workspace = trueresolver = "1"declarations from 6 sub-cratesAre there any user-facing changes?
No.
How was this patch tested?
Verified with
cargo check --workspace- all crates compile successfully with the unified configuration.