ARROW-1384: [C++] Add SerializeRecordBatch API for writing a record batch as an IPC message to a new buffer#984
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-1384: [C++] Add SerializeRecordBatch API for writing a record batch as an IPC message to a new buffer#984wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
…r arguments const Change-Id: I550d70f4fe30e9f3e8050889c409ca5293708477
pcmoritz
reviewed
Aug 22, 2017
| std::shared_ptr<RecordBatchStreamWriter> writer; | ||
| RETURN_NOT_OK(RecordBatchStreamWriter::Open(dst, batches[0]->schema(), &writer)); | ||
| for (const auto& batch : batches) { | ||
| // allow sizes > INT32_MAX |
Contributor
There was a problem hiding this comment.
Consider adding a DCHECK_EQ(batches[0]->schema(), batch->schema()) or similar
Change-Id: If097de5f2823a81b7d0f04dfe3712d2b9686c795
Contributor
|
+1 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's also a little bit of API scrubbing as I went through this code.