ARROW-10471: [CI][Python] Ensure we have tests with s3fs and run those on CI#8573
Closed
jorisvandenbossche wants to merge 13 commits into
Closed
ARROW-10471: [CI][Python] Ensure we have tests with s3fs and run those on CI#8573jorisvandenbossche wants to merge 13 commits into
jorisvandenbossche wants to merge 13 commits into
Conversation
Member
Author
There was a problem hiding this comment.
@kszucs is it fine to simply change this like the above? Or does something else need to be updated as well?
CI for this build seems to pass, but the "Python / docker" one fails (this is fixed now)
(I am changing "pandas-latest" to use 3.7, as right now we have many builds using 3.6, and almost none using 3.7, eg the pandas 0.23 above also uses python 3.6)
Member
There was a problem hiding this comment.
SGTM, the parametrization is right.
jorisvandenbossche
force-pushed
the
ARROW-10471-s3fs
branch
from
November 9, 2020 10:46
ceff7ed to
2512fbb
Compare
jorisvandenbossche
changed the title
Member
|
@ursabot build |
This was referenced Nov 9, 2020
pitrou
pushed a commit
that referenced
this pull request
Nov 12, 2020
Follow-up on #8573, where I introduced a test that was only passing because of state from other S3 tests. Closes #8638 from jorisvandenbossche/ARROW-10558 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.