Skip to content

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+#8216

Closed
trxcllnt wants to merge 5 commits into
apache:masterfrom
trxcllnt:fix/typescript-3.9-errors
Closed

ARROW-8394: [JS] Upgrade to TypeScript 4.0.2, fix typings for TS 3.9+#8216
trxcllnt wants to merge 5 commits into
apache:masterfrom
trxcllnt:fix/typescript-3.9-errors

Conversation

@trxcllnt

@trxcllnt trxcllnt commented Sep 18, 2020

Copy link
Copy Markdown
Contributor
  • Upgrades to TypeScript 4.0.2
  • Fixes typings for TypeScript versions 3.9+

Closes https://issues.apache.org/jira/browse/ARROW-8394

@github-actions

github-actions Bot commented Sep 18, 2020

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-8394

@trxcllnt

trxcllnt commented Sep 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@kszucs recent node versions changed behavior of one of the stream properties we're testing, so node 11 will fail now.

I tried updating all references to node v11, but I'm not sure how to update the Ursabot / AMD64 Debian 9 NodeJS 11 build. Is this something we can update and include in this PR?

@kszucs

kszucs commented Sep 18, 2020

Copy link
Copy Markdown
Member

Thanks for the update! I'll handle the ursabot builder.

@TheNeuralBit

TheNeuralBit commented Sep 18, 2020

Copy link
Copy Markdown
Member

Thanks Paul! I should have time to take a look over the weekend

TheNeuralBit
TheNeuralBit reviewed Sep 21, 2020
View reviewed changes

@TheNeuralBit TheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trxcllnt! Couple questions/comments

Comment thread js/src/interfaces.ts
Comment thread js/src/data.ts
Comment thread js/test/Arrow.ts
Comment thread js/test/inference/column.ts
Comment thread js/test/unit/ipc/helpers.ts
Comment thread js/package.json
Comment thread .env
@kszucs

kszucs commented Sep 23, 2020

Copy link
Copy Markdown
Member

@ursabot build

@kszucs

kszucs commented Sep 23, 2020

Copy link
Copy Markdown
Member

The Ursabot / AMD64 Debian 9 NodeJS 11 builder is no longer enabled in favor of Ursabot / AMD64 Debian 9 NodeJS 14, so it should be good to go from the buildbot side.

@nealrichardson

nealrichardson commented Oct 5, 2020

Copy link
Copy Markdown
Member

@trxcllnt Is this ready to merge?

@trxcllnt

trxcllnt commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@nealrichardson yeah I believe so

@tconkling

tconkling commented Oct 5, 2020

Copy link
Copy Markdown

Thanks a lot for your work on this, @trxcllnt! Really excited for this to land in a release.

@nevi-me nevi-me mentioned this pull request Dec 3, 2020
Closed
@asfimport asfimport mentioned this pull request Jan 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheNeuralBit TheNeuralBit TheNeuralBit left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trxcllnt @kszucs @TheNeuralBit @nealrichardson @tconkling