ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels - #7656

Closed

maartenbreddels wants to merge 28 commits into

apache:masterfrom

maartenbreddels:ARROW-9268

Commits on Jul 12, 2020

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

maartenbreddels
authored and
wesm
committed
2cd1d8b
lint python

maartenbreddels
authored and
wesm
committed
08e2898
convert arrow scalar to python value

maartenbreddels
authored and
wesm
committed
c85837a
move utf8proc code to ifdef block

maartenbreddels
authored and
wesm
committed
afd2207
remove unused variable

maartenbreddels
authored and
wesm
committed
ad1c1ac
use UTF8PROC_CATEGORY_CN instead of 0

maartenbreddels
authored and
wesm
committed
a1f9935
better version of islower/isupper using trick and more tests

maartenbreddels
authored and
wesm
committed
ae9a111
put tests in place that document what we do not support

maartenbreddels
authored and
wesm
committed
bdb040c
make python tests more robust by ignoring undefined codepoints

maartenbreddels
authored and
wesm
committed
3c59966
rename string_func_unicode -> utf8_func

maartenbreddels
authored and
wesm
committed
e01cf19
more tests

maartenbreddels
authored and
wesm
committed
674aa38
some compilers look at unused templates

maartenbreddels
authored and
wesm
committed
35091f5
misplaced ifdefs

maartenbreddels
authored and
wesm
committed
876e1b8
use lookup table and use isalnum for benchmark

maartenbreddels
authored and
wesm
committed
5227023
use utf8 sequence in string (maybe the compiler does not like the literal utf8 char if it does not recognize it?)

maartenbreddels
authored and
wesm
committed
65d674d
Fix: was not using lut

maartenbreddels
authored and
wesm
committed
cd426d4
performance increase: ~15-20%

maartenbreddels
authored and
wesm
committed
b435b94
use different high codepoint that does not require unicode 13

maartenbreddels
authored and
wesm
committed
cb9365c
Use 'ArrowType' for template parameter instead of clashing 'StringType'
wesm
committed
f7a4931
compiler bug workaround

maartenbreddels
authored and
wesm
committed
1e8c5c5
wrong template argument

maartenbreddels
authored and
wesm
committed
68868bd
change crtp inheritance

maartenbreddels
authored and
wesm
committed
3739e66
CRTP -> inline lambdas
wesm
committed
e9628a6
Instantiate fewer templates
wesm
committed
33bb8bb
Some fixes, try something else to see if it fixes the gcc compilation issue
wesm
committed
a160803
Move LUT initialization out of if block
wesm
committed
2efd9c8
Compile without utf8proc
wesm
committed
ce7869d
Skip failing test on older utf8proc
wesm
committed
bc5a2ec

Navigation Menu

Uh oh!

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels - #7656

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels#7656
maartenbreddels wants to merge 28 commits into
apache:masterfrom
maartenbreddels:ARROW-9268

Commits on Jul 12, 2020

ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

lint python

convert arrow scalar to python value

move utf8proc code to ifdef block

remove unused variable

use UTF8PROC_CATEGORY_CN instead of 0

better version of islower/isupper using trick and more tests

put tests in place that document what we do not support

make python tests more robust by ignoring undefined codepoints

rename string_func_unicode -> utf8_func

more tests

some compilers look at unused templates

misplaced ifdefs

use lookup table and use isalnum for benchmark

use utf8 sequence in string (maybe the compiler does not like the literal utf8 char if it does not recognize it?)

Fix: was not using lut

performance increase: ~15-20%

use different high codepoint that does not require unicode 13

Use 'ArrowType' for template parameter instead of clashing 'StringType'

compiler bug workaround

wrong template argument

change crtp inheritance

CRTP -> inline lambdas

Instantiate fewer templates

Some fixes, try something else to see if it fixes the gcc compilation issue

Move LUT initialization out of if block

Compile without utf8proc

Skip failing test on older utf8proc