Skip to content

ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel - #7312

Closed
wesm wants to merge 3 commits into
apache:masterfrom
wesm:ARROW-8937
Closed

ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel#7312
wesm wants to merge 3 commits into
apache:masterfrom
wesm:ARROW-8937

Conversation

@wesm

@wesm wesm commented Jun 1, 2020

Copy link
Copy Markdown
Member

For now, this is not exposed in any public APIs beyond using CallFunction to invoke it.

@github-actions

github-actions Bot commented Jun 1, 2020

Copy link
Copy Markdown

Comment thread cpp/src/arrow/compute/kernels/scalar_string.cc Outdated
Comment thread cpp/src/arrow/compute/test_util.h Outdated
wesm and others added 2 commits June 2, 2020 09:58
Add a unit test for the OutputType::Resolve changes

Create kernels/test_util.cc
@wesm

wesm commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

+1. Will merge once CI is green

@wesm

wesm commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

The ARM failure looks like a flake

/usr/bin/ccache /usr/bin/c++  -DARROW_EXPORTING -DARROW_HAVE_NEON -DARROW_HDFS -DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_NO_DEPRECATED_API -DARROW_USE_GLOG -DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DURI_STATIC_BUILD -Isrc -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/thirdparty/flatbuffers/include -isystem jemalloc_ep-prefix/src -isystem googletest_ep-prefix/include -isystem /arrow/cpp/thirdparty/hadoop/include -isystem orc_ep-install/include -Wno-noexcept-type  -fdiagnostics-color=always -ggdb -O0  -Wall -Wno-conversion -Wno-sign-conversion -Wno-unused-variable -Werror -march=armv8-a  -g -fPIC   -std=gnu++11 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o -c /arrow/cpp/src/arrow/compute/kernels/vector_take.cc
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

This may be related to code size -- some near-term refactoring I am undertaking in this file should address that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants