ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel - #7312
Closed
wesm wants to merge 3 commits into
Closed
ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel#7312wesm wants to merge 3 commits into
wesm wants to merge 3 commits into
Conversation
pitrou
reviewed
Jun 2, 2020
Add a unit test for the OutputType::Resolve changes Create kernels/test_util.cc
Member
Author
|
+1. Will merge once CI is green |
Member
Author
|
The ARM failure looks like a flake This may be related to code size -- some near-term refactoring I am undertaking in this file should address that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, this is not exposed in any public APIs beyond using
CallFunctionto invoke it.