Skip to content

ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64#7049

Closed
rtyler wants to merge 1 commit into
apache:masterfrom
rtyler:aarch64-fixes
Closed

ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64#7049
rtyler wants to merge 1 commit into
apache:masterfrom
rtyler:aarch64-fixes

Conversation

@rtyler

@rtyler rtyler commented Apr 28, 2020

Copy link
Copy Markdown
Contributor 
error[E0432]: unresolved import `crate::compute::util::simd_load_set_invalid`
--> /home/tyler/.cargo/git/checkouts/arrow-3a9cfebb6b7b2bdc/2a8e37d/rust/arrow/src/compute/kernels/arithmetic.rs:42:5
|
42 | use crate::compute::util::simd_load_set_invalid;
|     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `simd_load_set_invalid` in `compute::util`

Compiling thiserror v1.0.16
error: aborting due to previous error

@rtyler
Avoid loading simd_load_set_invalid which doesn't exist on aarch64
8cb004b 
    error[E0432]: unresolved import `crate::compute::util::simd_load_set_invalid`
    --> /home/tyler/.cargo/git/checkouts/arrow-3a9cfebb6b7b2bdc/2a8e37d/rust/arrow/src/compute/kernels/arithmetic.rs:42:5
    |
    42 | use crate::compute::util::simd_load_set_invalid;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `simd_load_set_invalid` in `compute::util`

    Compiling thiserror v1.0.16
    error: aborting due to previous error
@rtyler

rtyler commented Apr 28, 2020

Copy link
Copy Markdown
Contributor Author

Fixing this also helps surface ARROW-8610, which I have had a hell of a time fixing

@fsaintjacques fsaintjacques changed the title Avoid loading simd_load_set_invalid which doesn't exist on aarch64 [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64 Apr 28, 2020
@paddyhoran

paddyhoran commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

Hi @rtyler,

I was going to suggest disabling SIMD as auto-vectorization seems to be adding SIMD by itself, see #7037. Also, on #7037 @nevi-me noticed the divide by zero problem.

Can you open a JIRA so I can assign it to you and I'll get this merged.

@rtyler

rtyler commented Apr 28, 2020

Copy link
Copy Markdown
Contributor Author

https://issues.apache.org/jira/browse/ARROW-8617

@paddyhoran

paddyhoran commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

Would you mind fixing the lint error also please (I know you didn't introduce this)?

@wesm wesm changed the title [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64 ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64 Apr 28, 2020
@nevi-me

nevi-me commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

Would you mind fixing the lint error also please (I know you didn't introduce this)?

We're fixing the lint error in #7024

paddyhoran
paddyhoran approved these changes Apr 28, 2020
View reviewed changes

@paddyhoran paddyhoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending getting #7024 merged. Thanks @rtyler

@paddyhoran

paddyhoran commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

I'm going to merge this.

@rtyler
rtyler deleted the aarch64-fixes branch April 28, 2020 20:53
@asfimport asfimport mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paddyhoran paddyhoran paddyhoran approved these changes

Assignees

No one assigned

Labels

Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rtyler @paddyhoran @nevi-me @fsaintjacques