ARROW-5112: [Go] implement writing IPC Arrow stream/file#4229
Closed
sbinet wants to merge 8 commits intoapache:masterfrom
Closed
ARROW-5112: [Go] implement writing IPC Arrow stream/file#4229sbinet wants to merge 8 commits intoapache:masterfrom
sbinet wants to merge 8 commits intoapache:masterfrom
Conversation
Contributor
Author
stuartcarnie
approved these changes
May 1, 2019
Contributor
stuartcarnie
left a comment
There was a problem hiding this comment.
It is a large PR, so I was looking though the commits for tests. I don't have a sense of the amount of coverage but I do see lots of tests.
LGTM 🎉
Contributor
Author
|
yeah... I don't know why the code coverage app didn't post its report... |
Codecov Report
@@ Coverage Diff @@
## master #4229 +/- ##
===========================================
- Coverage 88.27% 71.83% -16.45%
===========================================
Files 763 71 -692
Lines 93723 5943 -87780
Branches 1251 0 -1251
===========================================
- Hits 82735 4269 -78466
+ Misses 10875 1446 -9429
- Partials 113 228 +115
Continue to review full report at Codecov.
|
7d58806 to
5b59ae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #4228.