GH-38703: [C++][FS][Azure] Implement DeleteFile()#39648
GH-38703: [C++][FS][Azure] Implement DeleteFile()#39648av8or1 wants to merge 0 commit intoapache:mainfrom av8or1:delete-file-branch
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
Sure, I'll do that straight away.
I did this at the time I opened the pull request. I suppose that it was the location within the template that I put my commentary that caused it to not be included? Dunno, but I'll revisit this and re-enter my original commentary.
Is that how conflicts should be resolved? I have not done a rebase in quite a while, so I'll go back and take a look at exactly what that means and how to proceed. I'll update this PR as I make progress. Thank you for the feedback. |
Rationale for this change
Completed the modifications to implement the DeleteFile() method to support deletion of files on ADLS.
What changes are included in this PR?
Modified:
~cpp/src/arrow/filesystem/azurerefs.cc
~cpp/src/arrow/filesystem/azurerefs_test.cc
These modifications implement the method and provide regression testing, respectively.
Are these changes tested?
I tested the modification by creating a file via the web browser on our internal ADLS, then ran a sample program that deleted the file. I added three regression tests to cover the use case scenarios of:
Are there any user-facing changes?
This is my first contribution to the Arrow library. Therefore I am not certain if the addition of a relatively low-level feature such as this would propagate to external documentation. That said, given the target audience of the library (developers), I would imagine that such a method would have documentation.
DeleteFile()#38703