ARROW-3844: [C++] Remove ARROW_USE_SSE and ARROW_SSE3

[pitrou]

Those options can be detected programmatically (SSE3 and SSE4.2 are available on all recent x86-64 CPUs).
Instead we add a ARROW_USE_SIMD option that can be disabled to exercise non-SIMD fallback paths.

[pitrou]

Note it is debatable whether some functions (such as CRC32 accelerations) are actually "SIMD". Someone may suggest another name if desired.

[pitrou]

Ah, there is a crash that is due to CrcHash not accepting a null pointer. This shows that the SSE paths in Parquet were entirely not tested.

[pitrou]

Rather than try to workaround the null pointer issue, I will wait for PR #3036 to be merged and then rebase this PR, since that will change the uses of hash functions by Parquet.

[fsaintjacques]

I think that SIMD is too broad term, e.g. the Altivec options just right underneath might be confused with this new naming.

[pitrou]

Well, the aim is really to provide a knob to disable all explicit use of optional instructions / intrinsics etc. in the source code. Currently -maltivec seems only used for autovectorization (there is no Altivec-dependent switch in the source).

[pitrou]

Rebased now.

[wesm]

+1

[wesm]

Rebasing again. Not sure what's broken about double-conversion in conda-forge today

[codecov-io]

Codecov Report

Merging #3037 into master will increase coverage by 1.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3037     +/-   ##
=========================================
+ Coverage   86.95%   88.06%   +1.1%     
=========================================
  Files         483      425     -58     
  Lines       68606    64888   -3718     
=========================================
- Hits        59658    57144   -2514     
+ Misses       8851     7744   -1107     
+ Partials       97        0     -97

Impacted Files	Coverage Δ
cpp/src/arrow/util/cpu-info.cc	75.32% <ø> (ø)	⬆️
cpp/src/arrow/util/bit-util.h	98.81% <ø> (ø)	⬆️
cpp/src/arrow/util/sse-util.h	100% <ø> (ø)	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	72.03% <0%> (-0.95%)	⬇️
go/arrow/array/table.go
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/null.go
... and 53 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd896c9...8adb98b. Read the comment docs.