ARROW-14817 [R] Implement bindings for `lubridate::tz()` - #12357

Closed

dragosmg wants to merge 35 commits into

apache:masterfrom

dragosmg:lubridate_tz_binding

Commits on Feb 7, 2022

first pass at implementing the binding for `lubridate::tz()`. needs more tests
dragosmg
committed
d6b66d2

Commits on Feb 8, 2022

`tz()` returns `"UTC"` for strings, date and NAs + more tests
dragosmg
committed
ebc1443
updated NEWS
dragosmg
committed
104c779

Commits on Feb 10, 2022

fall back to the simpler implementation for `tz()`
dragosmg
committed
9710ffd
split good and error behaviour in 2 different chunks and use `expect_snapshot()` for the error chunk
dragosmg
committed
38e38e0
update `tz()` binding to return `NA` when x is `NA`
dragosmg
committed
d88e4c9
update tests to reflect different behaviour for `NA`: arrow returns `NA`, lubridate returns `"UTC"`
dragosmg
committed
ff23580
revert to first / original implementation and remove NA propagation unit test
dragosmg
committed
6014efa

Commits on Feb 15, 2022

Commits on Feb 16, 2022

some clean up
jonkeane
committed
d47fd4d

Commits on Feb 17, 2022

removed snapshot md file
dragosmg
committed
14d3ac4
class extraction
dragosmg
committed
52067c9
simplify class extraction once #12447 is merged
dragosmg
committed
792f4ae

Commits on Feb 19, 2022

first pass at implementing the binding for `lubridate::tz()`. needs more tests

dragosmg
authored and
jonkeane
committed
d1d5946
`tz()` returns `"UTC"` for strings, date and NAs + more tests

dragosmg
authored and
jonkeane
committed
91c5e66
updated NEWS

dragosmg
authored and
jonkeane
committed
46080f6
fall back to the simpler implementation for `tz()`

dragosmg
authored and
jonkeane
committed
0233ec5
split good and error behaviour in 2 different chunks and use `expect_snapshot()` for the error chunk

dragosmg
authored and
jonkeane
committed
de7f992
update `tz()` binding to return `NA` when x is `NA`

dragosmg
authored and
jonkeane
committed
07c2a65
update tests to reflect different behaviour for `NA`: arrow returns `NA`, lubridate returns `"UTC"`

dragosmg
authored and
jonkeane
committed
0936441
revert to first / original implementation and remove NA propagation unit test

dragosmg
authored and
jonkeane
committed
de648f4
updated unit tests and snapshots for `tz()`

dragosmg
authored and
jonkeane
committed
165031c
update `tz()` with more meaningful error messages

dragosmg
authored and
jonkeane
committed
30e2cea
meaningful names for the test dataframe columns + update snapshots

dragosmg
authored and
jonkeane
committed
384fddc
simplify the implementation (start with timestamp & error for anything else)

dragosmg
authored and
jonkeane
committed
af96552
some clean up
jonkeane
committed
3cee34a
removed snapshot md file

dragosmg
authored and
jonkeane
committed
fa75502
class extraction

dragosmg
authored and
jonkeane
committed
4bf48f6
simplify class extraction once #12447 is merged

dragosmg
authored and
jonkeane
committed
554345b
a few test additions|changes
jonkeane
committed
3bff651

Commits on Feb 21, 2022