Skip to content

ARROW-15358: [C++] Fix custom matcher compilation - #12181

Closed
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-15358-matcher-compilation
Closed

ARROW-15358: [C++] Fix custom matcher compilation#12181
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-15358-matcher-compilation

Conversation

@pitrou

@pitrou pitrou commented Jan 18, 2022

Copy link
Copy Markdown
Member

No description provided.

@pitrou
pitrou requested a review from lidavidm January 18, 2022 14:50
lidavidm
lidavidm approved these changes Jan 18, 2022
View reviewed changes

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I suppose the macro shortcut implementation is only in recent versions of GTest.

@pitrou

pitrou commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

Actually, it may have moved from one .h to the other.

@pitrou

pitrou commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

CI green on my fork: pitrou@7abb204

@pitrou pitrou closed this in cd30dea Jan 18, 2022
@pitrou
pitrou deleted the ARROW-15358-matcher-compilation branch January 18, 2022 16:18
@ursabot

ursabot commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = e28b3a0 and contender = cd30dea. cd30dea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@github-actions

github-actions Bot commented Jan 18, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-15358

@asfimport asfimport mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou @ursabot @lidavidm