ARROW-1528: [GLib] Resolve recursive include dependency - #1091
Closed
kou wants to merge 2 commits into
Closed
Conversation
Before:
* arrow-glib/field.h depends on arrow-glib/data-type.h
* arrow-glib/data-type.h depends on arrow-glib/field.h
After:
* arrow-glib/field.h depends on arrow-glib/basic-data-type.h
* arrow-glib/basic-data-type.h doesn't depend on arrow-glib/field.h
* arrow-glib/composite-data-type.h depends on
arrow-glib/basic-data-type.h and
arrow-glib/composite-data-type.h
wesm
approved these changes
Sep 12, 2017
wesm
left a comment
wesm
left a comment
Member
There was a problem hiding this comment.
+1. Looks like there's an error with the doc build. I'm going to look at the macOS failure since the release candidate needs to go out today
Member
Author
|
Oh... I'm checking now. |
Member
|
ah ok, I'll wait for you and enjoy some coffee, then. thanks @kou! =) |
Member
|
One last test :3 |
Member
|
bah |
Member
|
blu blu blu |
Member
|
hmm |
Member
Author
|
It works again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
arrow-glib/basic-data-type.h and
arrow-glib/composite-data-type.h