ARROW-9056: [C++] Support aggregations over scalars - #10725
Closed
lidavidm wants to merge 10 commits into
Closed
Conversation
bkietz
self-requested a review
July 15, 2021 17:53
nealrichardson
requested changes
Jul 15, 2021
nealrichardson
left a comment
nealrichardson
left a comment
Member
There was a problem hiding this comment.
There are a couple of skipped tests for this in the R package, could you remove the skips? (Just search for "ARROW-9056")
bkietz
requested changes
Jul 15, 2021
bkietz
left a comment
bkietz
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this!
Two high level comments:
bkietz
requested changes
Jul 15, 2021
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Member
Author
|
Fixed the MSVC failure + rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds various trivial implementations to support scalar aggregations over scalar inputs, for all kernels except
index.