ARROW-12952: [C++] Add count_substring_regex - #10471
Closed
lidavidm wants to merge 2 commits into
Closed
Conversation
Member
|
Can you rebase this @lidavidm ? |
Member
Author
|
Rebased, thanks for the reminder. |
pitrou
approved these changes
Jun 10, 2021
Member
There was a problem hiding this comment.
Nit, but may use offset_bit_width() from type_traits.h
(e.g offset_bit_width(ty->id()) == 64 ? int64() : int32())
Member
|
Hmm, there are conflicts now... |
Member
Author
|
It's because the tests overlap/I forgot to rename & move the test case for ascii_replace_slice (now done). |
Member
|
Feel free to merge if CI green! |
Member
Author
|
Thanks for the review! CI green other than the usual culprits, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds the regular case-insensitive count_substring.