ARROW-2665: [C++][Python] Add index() kernel - #10358
Closed
lidavidm wants to merge 5 commits into
Closed
Conversation
lidavidm
force-pushed
the
arrow-2665
branch
2 times, most recently
from
May 19, 2021 21:36
0f93560 to
38fbe6e
Compare
cyb70289
reviewed
May 20, 2021
cyb70289
reviewed
May 21, 2021
cyb70289
approved these changes
May 21, 2021
cyb70289
left a comment
cyb70289
left a comment
Contributor
There was a problem hiding this comment.
+1.
CI errors looks not related.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple index() kernel.
Note that the Python start/end options are handled entirely in Python, not in the kernel itself.
Short-circuiting is somewhat implemented: the kernel executor will still loop through all batches but the kernel will stop looking at data once it finds an item.